[
https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=466737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466737
]
ASF GitHub Bot logged work on IO-670:
-------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/20 11:23
Start Date: 05/Aug/20 11:23
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669137557
Also, the existing prefix we use is Undynchronized, not Unsync.
Gary
On Wed, Aug 5, 2020, 05:48 sebbASF <[email protected]> wrote:
> AFAICT the new classes UnsyncBufferedReader etc are not actually used
> (except in test code).
>
> I would expect all the contentEquals methods to remain exactly the same
> except for changes to the input sources.
> The logic should remain unchanged (otherwise the new classes are not
> proper replacements).
>
> Likewise I would not expect to see any changes to test cases, only new
> ones for the new classes, and perhaps a few new samples for existing
> methods where the coverage is incomplete.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/commons-io/pull/118#issuecomment-669097163>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAJB6N4YDKEPR6TRS52YASDR7ETIJANCNFSM4NP6TZTQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 466737)
Time Spent: 10h (was: 9h 50m)
> IOUtils.contentEquals is of low performance. I will refine it.
> --------------------------------------------------------------
>
> Key: IO-670
> URL: https://issues.apache.org/jira/browse/IO-670
> Project: Commons IO
> Issue Type: Improvement
> Reporter: Jin Xu
> Priority: Critical
> Attachments: jmh-result.org.apache.json
>
> Time Spent: 10h
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-io/pull/118]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
