XenoAmess commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669180712
> Do you have any proof that using UnsyncBufferedReader etc in contentEquals
will result in a slow-down unless further changes are made to contentEquals?
Yes, I ran a rough performance test on a same pc, and the result be time
9e8.(the current version of this pr shows 4.6e8, and master 2.8e9)
> If so, what further changes are needed to contentEquals, and what is the
speed improvement?
That trick only be possible when we comparing two(or several) InputReaders.
I shared an index on them, thus the two buffer's index be a same local
variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
