[
https://issues.apache.org/jira/browse/IO-676?focusedWorklogId=467284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467284
]
ASF GitHub Bot logged work on IO-676:
-------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/20 13:32
Start Date: 06/Aug/20 13:32
Worklog Time Spent: 10m
Work Description: Isira-Seneviratne commented on pull request #124:
URL: https://github.com/apache/commons-io/pull/124#issuecomment-669928664
>
>
> > > @Isira-Seneviratne @chtompki
> > > Here is another thought which I think will give us more bang for the
buck:
> > > All of these `FileUtils` time comparison APIs should convert their
input `File` object to a`Path` with `toPath()` and forward the calls to
`PathUtils` which opens the feature to any backing NIO file system, not old
school `File` objects.
> >
> >
> > That sounds like a good idea.
> > However, there's a potential issue in that those methods would become
unusable on most versions of Android, since the `java.nio.file` package is only
supported on Android Oreo and higher (admittedly, I'm not sure if any Android
apps will need to make use of those methods, and it's possible that the package
[will be made available](https://issuetracker.google.com/issues/154309654) to
all versions of Android via
[desugaring](https://developer.android.com/studio/write/java8-support-table)).
> > Other than that, sounds good to me :)
>
> Hi @Isira-Seneviratne
>
> After playing around a bit, I think I will proceed with this PR as is and
leave a refactoring for later.
Great!
>
> TBH, I had not considered Android. Would you have time to research if
there is a way to build and test for Android on GitHub Actions and/or Travis-CI?
Sure :)
On that note, I've made use of some of the methods in some apps I've
contributed to, and they work great:
https://github.com/BOINC/boinc/tree/master/android/BOINC
https://invent.kde.org/network/kdeconnect-android
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 467284)
Time Spent: 4h 20m (was: 4h 10m)
> Add isFileNewer() and isFileOlder() methods that support the Java 8 Date/Time
> API.
> ----------------------------------------------------------------------------------
>
> Key: IO-676
> URL: https://issues.apache.org/jira/browse/IO-676
> Project: Commons IO
> Issue Type: Improvement
> Components: Utilities
> Reporter: Isira Seneviratne
> Priority: Major
> Fix For: 2.8
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
