[ 
https://issues.apache.org/jira/browse/CONFIGURATION-792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kiesel updated CONFIGURATION-792:
-----------------------------------------
    Description: 
CONFIGURATION-556 changed how ConfigurationConverter.getConfiguration works: in 
1.9, the Properties content was read into a newly created HashMap but in 1.10 
this was changed to use the Properties as backing.  While this allows to have 
changes to the Properties immediately reflected in the configuration, it breaks 
code that adds new entries to such a configuration.

Example:
{code:java}
Properties properties = new Properties();
properties.load(Files.newInputStream(Paths.get("sample.properties")));
Configuration conf = ConfigurationConverter.getConfiguration(properties);
conf.setProperty("version", "1.10");
{code}
will work in 1.9 but result in a NPE in 1.10.

I understand that there are conflicting goals (compatibility with 1.7 or 1.9) 
but I think this should minimally be listed as a potential problem for upgrades 
to 1.10

 

 

  was:
CONFIGURATION-556 changed how ConfigurationConverter.getConfiguration works: in 
1.9, the Properties content was read into a newly created HashMap but in 1.10 
this was changed to use the Properties as backing.  While this allows to have 
changes to the Properties immediately reflected in the configuration, it breaks 
code that adds new entries to such a configuration.

Example:

 
{code:java}
Properties properties = new Properties();
properties.load(Files.newInputStream(Paths.get("sample.properties")));
Configuration conf = ConfigurationConverter.getConfiguration(properties);
configuration.setProperty("version", "1.10");
{code}
will work in 1.9 but result in a NPE in 1.10.

I understand that there are conflicting goals (compatibility with 1.7 or 1.9) 
but I think this should minimally be listed as a potential problem for upgrades 
to 1.10

 

 


> commons-configuration 1.10 breaks code that worked with 1.9
> -----------------------------------------------------------
>
>                 Key: CONFIGURATION-792
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-792
>             Project: Commons Configuration
>          Issue Type: Bug
>    Affects Versions: 1.10
>            Reporter: Norbert Kiesel
>            Priority: Major
>
> CONFIGURATION-556 changed how ConfigurationConverter.getConfiguration works: 
> in 1.9, the Properties content was read into a newly created HashMap but in 
> 1.10 this was changed to use the Properties as backing.  While this allows to 
> have changes to the Properties immediately reflected in the configuration, it 
> breaks code that adds new entries to such a configuration.
> Example:
> {code:java}
> Properties properties = new Properties();
> properties.load(Files.newInputStream(Paths.get("sample.properties")));
> Configuration conf = ConfigurationConverter.getConfiguration(properties);
> conf.setProperty("version", "1.10");
> {code}
> will work in 1.9 but result in a NPE in 1.10.
> I understand that there are conflicting goals (compatibility with 1.7 or 1.9) 
> but I think this should minimally be listed as a potential problem for 
> upgrades to 1.10
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to