garydgregory commented on a change in pull request #120:
URL: https://github.com/apache/commons-compress/pull/120#discussion_r468544838
##########
File path:
src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java
##########
@@ -1090,7 +1108,13 @@ private void readFilesInfo(final ByteBuffer header,
final Archive archive) throw
++emptyFileCounter;
}
}
- archive.files = files;
+ List<SevenZArchiveEntry> entries = new ArrayList<>();
Review comment:
+1
I use `final` as much as possible to make it obvious when reading or
debugging whether I need to even think about a given local variable, for more
details on my reasoning, please see
https://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
