nishantc1527 commented on pull request #602: URL: https://github.com/apache/commons-lang/pull/602#issuecomment-672546570
> Hi. > It actually breaks BC... > the original code can handle surrogate pairs. > you can see details in StringBuilder's source codes. Sorry, I don't know what surrogate pairs are... do you mind explaining? > besides, you should run a jmh test to show the performance incresement. > see HashSetvBitSetTest for example. Doing that now! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
