nhojpatrick commented on pull request #58: URL: https://github.com/apache/commons-codec/pull/58#issuecomment-674397112
@garydgregory the scripts should not be hacked locally. I executed `mvn -N io.takari:maven:0.7.7:wrapper` and added the changes. Maven v3.7.0 will have a similar command line once v3.7.0 is released. From experience the mvnw and mvnw.cmd and change very little and each time it's been updated i've just done `mvn -N io.takari:maven:NEW_VERSION:wrapper` and committed the changes that plugin did. Honestly it results in less maintenance and is easier for developers once you switch. Say commons-codec needs maven v3.6.0, well that version is just configure via this file `.mvn/wrapper/maven-wrapper.properties` using this line `distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.6.0/apache-maven-3.6.0-bin.zip` Your CI/CD servers etc don't need maven pre installed Any new developers and contributors don't need to install v3.6.0 and change their paths. Say commons-codec now wants to upgrade to v3.6.3, change `.mvn/wrapper/maven-wrapper.properties` to contain `distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip` CI/CD and Developers just keep executing ./mvnw and v3.6.3 is automatically downloaded and caches into your ~/.m2/wrappers. So no need to change your CI/CD docker images, or jenkins slaves to add v3.6.3. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
