sebbASF commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-674532472
You are correct - I was forgetting that the characters could be missing. As to testing the length, yes I think we do need to test for various lengths. Longer substrings may take longer to create; if that is true it should show that the new code is better. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
