[
https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=471353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-471353
]
ASF GitHub Bot logged work on LANG-1576:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Aug/20 05:54
Start Date: 17/Aug/20 05:54
Worklog Time Spent: 10m
Work Description: XenoAmess commented on pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#issuecomment-674672119
Hi.
I added some more lengths of Strings to the benchmark, as suggested by
@sebbASF . Thanks.
full benchmark at https://pastebin.ubuntu.com/p/yPH4xnKqZd/
In short,
```
Benchmark (data) (name) Mode
Cnt Score Error Units
StringUtilsChompTest.singleString NULL old avgt
5 3.246 ? 0.091 ns/op
StringUtilsChompTest.singleString NULL new avgt
5 3.265 ? 0.153 ns/op
StringUtilsChompTest.singleString CHAR0 old avgt
5 3.901 ? 0.251 ns/op
StringUtilsChompTest.singleString CHAR0 new avgt
5 3.863 ? 0.769 ns/op
StringUtilsChompTest.singleString CHAR0_CR old avgt
5 4.393 ? 0.519 ns/op
StringUtilsChompTest.singleString CHAR0_CR new avgt
5 4.335 ? 0.393 ns/op
StringUtilsChompTest.singleString CHAR0_LF old avgt
5 4.279 ? 0.295 ns/op
StringUtilsChompTest.singleString CHAR0_LF new avgt
5 4.315 ? 0.230 ns/op
StringUtilsChompTest.singleString CHAR0_CR_LF old avgt
5 10.768 ? 0.643 ns/op
StringUtilsChompTest.singleString CHAR0_CR_LF new avgt
5 9.901 ? 0.136 ns/op
StringUtilsChompTest.singleString CHAR1 old avgt
5 4.358 ? 0.257 ns/op
StringUtilsChompTest.singleString CHAR1 new avgt
5 3.989 ? 0.117 ns/op
StringUtilsChompTest.singleString CHAR1_CR old avgt
5 19.181 ? 0.715 ns/op
StringUtilsChompTest.singleString CHAR1_CR new avgt
5 19.502 ? 1.590 ns/op
StringUtilsChompTest.singleString CHAR1_LF old avgt
5 20.168 ? 1.003 ns/op
StringUtilsChompTest.singleString CHAR1_LF new avgt
5 19.578 ? 0.575 ns/op
StringUtilsChompTest.singleString CHAR1_CR_LF old avgt
5 19.984 ? 1.332 ns/op
StringUtilsChompTest.singleString CHAR1_CR_LF new avgt
5 19.834 ? 1.017 ns/op
StringUtilsChompTest.singleString CHAR2 old avgt
5 4.408 ? 0.098 ns/op
StringUtilsChompTest.singleString CHAR2 new avgt
5 4.033 ? 0.231 ns/op
StringUtilsChompTest.singleString CHAR2_CR old avgt
5 19.056 ? 1.116 ns/op
StringUtilsChompTest.singleString CHAR2_CR new avgt
5 18.928 ? 0.903 ns/op
StringUtilsChompTest.singleString CHAR2_LF old avgt
5 21.658 ? 2.624 ns/op
StringUtilsChompTest.singleString CHAR2_LF new avgt
5 20.125 ? 1.185 ns/op
StringUtilsChompTest.singleString CHAR2_CR_LF old avgt
5 19.865 ? 0.865 ns/op
StringUtilsChompTest.singleString CHAR2_CR_LF new avgt
5 20.033 ? 1.695 ns/op
StringUtilsChompTest.singleString CHAR1024 old avgt
5 4.469 ? 0.186 ns/op
StringUtilsChompTest.singleString CHAR1024 new avgt
5 4.051 ? 0.146 ns/op
StringUtilsChompTest.singleString CHAR1024_CR old avgt
5 102.333 ? 1.823 ns/op
StringUtilsChompTest.singleString CHAR1024_CR new avgt
5 102.237 ? 0.913 ns/op
StringUtilsChompTest.singleString CHAR1024_LF old avgt
5 104.155 ? 2.604 ns/op
StringUtilsChompTest.singleString CHAR1024_LF new avgt
5 103.365 ? 2.392 ns/op
StringUtilsChompTest.singleString CHAR1024_CR_LF old avgt
5 103.665 ? 4.241 ns/op
StringUtilsChompTest.singleString CHAR1024_CR_LF new avgt
5 103.453 ? 1.482 ns/op
StringUtilsChompTest.singleString CHAR10240 old avgt
5 4.772 ? 1.314 ns/op
StringUtilsChompTest.singleString CHAR10240 new avgt
5 4.064 ? 0.085 ns/op
StringUtilsChompTest.singleString CHAR10240_CR old avgt
5 981.277 ? 15.790 ns/op
StringUtilsChompTest.singleString CHAR10240_CR new avgt
5 985.230 ? 13.679 ns/op
StringUtilsChompTest.singleString CHAR10240_LF old avgt
5 983.508 ? 15.570 ns/op
StringUtilsChompTest.singleString CHAR10240_LF new avgt
5 1000.211 ? 48.633 ns/op
StringUtilsChompTest.singleString CHAR10240_CR_LF old avgt
5 990.806 ? 7.380 ns/op
StringUtilsChompTest.singleString CHAR10240_CR_LF new avgt
5 990.001 ? 9.229 ns/op
StringUtilsChompTest.singleString CHAR102400 old avgt
5 4.474 ? 0.142 ns/op
StringUtilsChompTest.singleString CHAR102400 new avgt
5 4.154 ? 0.325 ns/op
StringUtilsChompTest.singleString CHAR102400_CR old avgt
5 10077.261 ? 616.639 ns/op
StringUtilsChompTest.singleString CHAR102400_CR new avgt
5 10002.896 ? 85.774 ns/op
StringUtilsChompTest.singleString CHAR102400_LF old avgt
5 10081.275 ? 64.053 ns/op
StringUtilsChompTest.singleString CHAR102400_LF new avgt
5 10085.129 ? 43.548 ns/op
StringUtilsChompTest.singleString CHAR102400_CR_LF old avgt
5 10044.759 ? 68.778 ns/op
StringUtilsChompTest.singleString CHAR102400_CR_LF new avgt
5 10097.769 ? 101.311 ns/op
StringUtilsChompTest.test_Random_Strings_New N/A N/A avgt
5 76270.389 ?1885.347 ns/op
StringUtilsChompTest.test_Random_Strings_Old N/A N/A avgt
5 82757.374 ?9869.516 ns/op
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 471353)
Time Spent: 7h 40m (was: 7.5h)
> refine StringUtils.chomp
> ------------------------
>
> Key: LANG-1576
> URL: https://issues.apache.org/jira/browse/LANG-1576
> Project: Commons Lang
> Issue Type: Sub-task
> Reporter: Jin Xu
> Priority: Minor
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/565]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
