[
https://issues.apache.org/jira/browse/NUMBERS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184174#comment-17184174
]
Gilles Sadowski commented on NUMBERS-149:
-----------------------------------------
bq. Maybe I shouldn't add the @Deprecated tag?
The code is the problem, not the annotation!
bq. adding a cache, which I think good,
This change is not innocuous at could be at odds with the design goals:
{{Fraction}} is meant to be a
[ValJO|https://blog.joda.org/2014/03/valjos-value-java-objects.html]. Thus
requires discussion (on the "dev" ML).
This issue should only deal with ensuring that the concept of "fraction" is
correctly implemented in [Numbers], trimming all the cruft (bloat and bugs)
from the class in [Lang] but using it to double-check the implementation in
[Numbers].
> port functions / tests in commons-lang for Fraction.
> ----------------------------------------------------
>
> Key: NUMBERS-149
> URL: https://issues.apache.org/jira/browse/NUMBERS-149
> Project: Commons Numbers
> Issue Type: Improvement
> Components: fraction
> Reporter: Jin Xu
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://github.com/apache/commons-numbers/pull/82
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
