[
https://issues.apache.org/jira/browse/NUMBERS-151?focusedWorklogId=474724&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-474724
]
ASF GitHub Bot logged work on NUMBERS-151:
------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/20 08:09
Start Date: 26/Aug/20 08:09
Worklog Time Spent: 10m
Work Description: aherbert commented on a change in pull request #84:
URL: https://github.com/apache/commons-numbers/pull/84#discussion_r477112917
##########
File path:
commons-numbers-core/src/test/java/org/apache/commons/numbers/core/ArithmeticUtilsTest.java
##########
@@ -435,6 +435,25 @@ void testIsPowerOfTwo() {
}
}
+ @Test
+ void testPowOptimize() {
Review comment:
This should be moved above the `testIsPowerOfTwo` method. I would rename
it to `testPowEdgeCases`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 474724)
Time Spent: 1.5h (was: 1h 20m)
> Performance refinement for ArithmeticUtils.pow
> ----------------------------------------------
>
> Key: NUMBERS-151
> URL: https://issues.apache.org/jira/browse/NUMBERS-151
> Project: Commons Numbers
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.0-beta1
> Reporter: Jin Xu
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Hi.
> right now ArithmeticUtils.pow(0,0) = 1, but not throw an Exception, which I
> think not quite right...
> Is it a bug?
> Anyway, we found a way to faster the calculate, so at least we can get an
> performance refine pr.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
