woonsan commented on a change in pull request #118:
URL: https://github.com/apache/commons-vfs/pull/118#discussion_r479811311
##########
File path:
commons-vfs2-jackrabbit2/src/main/java/org/apache/commons/vfs2/provider/webdav4/Webdav4FileObject.java
##########
@@ -544,7 +544,8 @@ DavPropertySet getPropertyNames(final GenericURLFileName
name) throws FileSystem
* @return The encoded URL String.
*/
private String hrefString(final GenericURLFileName name) {
- final GenericURLFileName newFile = new GenericURLFileName("http",
name.getHostName(), name.getPort(), name.getDefaultPort(),
+ final String scheme = getHttpScheme(name);
Review comment:
`#getHttpScheme(name)` is unnecessary if you just use
`getInternalURI().getScheme()` and move the line into try ~ catch block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
