garydgregory commented on pull request #117:
URL: https://github.com/apache/commons-vfs/pull/117#issuecomment-690797731


   Hi @satish-csi 
   You need better tests.
   The tests don't show that anything was fixed because they succeed when run 
without the changes to `src/main`.
   I expect:
   - Apply patch to `src/test` only
   - New tests fail
   - Apply remainder of the patch to `src/main`
   - All tests pass
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to