kinow commented on a change in pull request #174:
URL: https://github.com/apache/commons-text/pull/174#discussion_r499134695
##########
File path:
src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java
##########
@@ -285,6 +286,11 @@ private static int limitedCompare(CharSequence left,
CharSequence right, final i
// left and up
d[i] = 1 + Math.min(Math.min(d[i - 1], p[i]), p[i - 1]);
}
+ lowerBound = Math.min(lowerBound, d[i]);
+ }
+ // if the lower bound is greater than the threshold, then exit
early
+ if (lowerBound > threshold) {
+ return -1;
Review comment:
Better update this one. We can squash/edit commits later if necessary
:+1: After you push a new commit I think the CI jobs will run again, and
coveralls will confirm the code is being tested now.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
