[
https://issues.apache.org/jira/browse/IMAGING-265?focusedWorklogId=495804&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495804
]
ASF GitHub Bot logged work on IMAGING-265:
------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/20 09:13
Start Date: 06/Oct/20 09:13
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #98:
URL: https://github.com/apache/commons-imaging/pull/98#discussion_r500125515
##########
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java
##########
@@ -53,14 +53,17 @@ public boolean stripsNotTiles() {
@Override
public ImageDataReader getDataReader(final TiffDirectory directory,
- final PhotometricInterpreter photometricInterpreter,
- final int bitsPerPixel, final int[] bitsPerSample, final int
predictor,
- final int samplesPerPixel, final int width, final int height,
final int compression,
- final ByteOrder byteOrder) throws IOException, ImageReadException {
+ final PhotometricInterpreter photometricInterpreter,
+ final int bitsPerPixel, final int[] bitsPerSample, final int
predictor,
+ final int samplesPerPixel, final int width, final int height,
+ final int compression,
+ final int planarConfiguration,
Review comment:
@gwlucastrig last change before merging this PR. We have some enum's
like `DisposalMethod`, `IptcTypes`, png `FilterType`, `TiffDirectoryType`…
I think we should create some enum like `TiffPlanarConfiguration` for this
setting. Do you think that would i) make sense and ii) work?
Nothing to add besides that, we have tests, code is in order, bug appears to
be fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 495804)
Time Spent: 2h 10m (was: 2h)
> ArrayIndexOutOfBoundsException on reading simple GeoTIFF
> --------------------------------------------------------
>
> Key: IMAGING-265
> URL: https://issues.apache.org/jira/browse/IMAGING-265
> Project: Commons Imaging
> Issue Type: Bug
> Components: Format: TIFF
> Affects Versions: 1.0-alpha2
> Reporter: edgar soldin
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Attachments: small_world.tif, small_world_split.jpg
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> hi,
>
> we on the OpenJUMP project cannot open some GeoTIFFs with commons.imaging .
> for details you may find a ticket in our bug tracker
> [https://sourceforge.net/p/jump-pilot/bugs/498/] .
>
> the gist is: on loading the attached file getBufferedImage() fails with this
> stack
> {noformat}
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 8000Caused by:
> java.lang.ArrayIndexOutOfBoundsException: 8000 at
> org.apache.commons.imaging.formats.tiff.datareaders.DataReaderStrips.interpretStrip(DataReaderStrips.java:196)
> at
> org.apache.commons.imaging.formats.tiff.datareaders.DataReaderStrips.readImageData(DataReaderStrips.java:254)
> at
> org.apache.commons.imaging.formats.tiff.TiffImageParser.getBufferedImage(TiffImageParser.java:665)
> at
> org.apache.commons.imaging.formats.tiff.TiffDirectory.getTiffImage(TiffDirectory.java:254)
> at
> org.apache.commons.imaging.formats.tiff.TiffImageParser.getBufferedImage(TiffImageParser.java:469)
> at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1442) at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1335) at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1304) at
> com.vividsolutions.jump.workbench.imagery.graphic.CommonsImage.initImage(CommonsImage.java:108){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
