[
https://issues.apache.org/jira/browse/COLLECTIONS-768?focusedWorklogId=497643&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497643
]
ASF GitHub Bot logged work on COLLECTIONS-768:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/20 22:45
Start Date: 08/Oct/20 22:45
Worklog Time Spent: 10m
Work Description: tongxin97 commented on pull request #189:
URL:
https://github.com/apache/commons-collections/pull/189#issuecomment-705861916
@kinow Thanks for taking a look. I'm under the impression that a regular
LinkedHashMap or a TreeMap with custom comparator could preserve insertion
order.
Btw I'm new to contributing to Apache projects, so for logistics, are you
(or someone else from your team) going to accept and merge this PR? Is there
anything more you need from my side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 497643)
Time Spent: 0.5h (was: 20m)
> Flat3MapTest.tesetEntrySet() is flaky
> -------------------------------------
>
> Key: COLLECTIONS-768
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-768
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
> Affects Versions: 4.4
> Reporter: XinT
> Priority: Minor
> Labels: easyfix, pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The testEntrySet() function
> (org.apache.commons.collections4.map.Flat3MapTest#testEntrySet) is flaky
> because it uses a flaky helper function putAndRemove(). The helper function
> wrongly assumes that map iterators execute in insertion order, while in fact
> it can be any order.
> The current test asserts the last element iterated (and subsequently removed)
> is the last element inserted. Therefore, the test passes when it so happens
> that the last iterated element is the last inserted element, but fails
> otherwise.
>
> The proposed fix is: https://github.com/apache/commons-collections/pull/189
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
