[
https://issues.apache.org/jira/browse/LANG-1519?focusedWorklogId=501176&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-501176
]
ASF GitHub Bot logged work on LANG-1519:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/20 16:57
Start Date: 15/Oct/20 16:57
Worklog Time Spent: 10m
Work Description: HubertWo commented on a change in pull request #495:
URL: https://github.com/apache/commons-lang/pull/495#discussion_r505697116
##########
File path: src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
##########
@@ -1575,4 +1582,867 @@ public void compareByte() {
assertEquals(0, NumberUtils.compare((byte) 113, (byte) 113));
assertTrue(NumberUtils.compare((byte) 123, (byte) 32) > 0);
}
+
+ @Test
+ void testIsZero() {
Review comment:
What about splitting this to small tests instead of one long test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 501176)
Time Spent: 5.5h (was: 5h 20m)
> Add zero, positive & negative util methods
> ------------------------------------------
>
> Key: LANG-1519
> URL: https://issues.apache.org/jira/browse/LANG-1519
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.*
> Reporter: Nivruth Nandigam
> Priority: Trivial
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Create util methods to determine if a number is zero, positive or negative
> (and also the negation of any of these scenarios)
>
> Pull Request: [https://github.com/apache/commons-lang/pull/495]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
