garydgregory commented on pull request #179: URL: https://github.com/apache/commons-text/pull/179#issuecomment-717328036
The existing method needs a review first IMO. For this patch though, I don't see why applying the function to a string should change its size, that's just weird to me. One problem I see with the current implementation is the use of the default character set in the call to toLowerCase(). At the very least, we need a test to account for the "Turkish Surprise", see https://garygregory.wordpress.com/2015/11/03/java-lowercase-conversion-turkey/ and see also the last comment about “Kedi”.toUpperCase() which I am not sure applies to title case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
