[
https://issues.apache.org/jira/browse/MATH-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221907#comment-17221907
]
Gilles Sadowski commented on MATH-1559:
---------------------------------------
bq. can mess up the probability
How often does it happen?
I'm a bit wary that changing the tolerance conveys the wrong impression about
the obviously expected result.
> testCreateFromDoubles can fail
> ------------------------------
>
> Key: MATH-1559
> URL: https://issues.apache.org/jira/browse/MATH-1559
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.6.1
> Reporter: XinT
> Priority: Minor
> Labels: pull-request-available, test
> Time Spent: 20m
> Remaining Estimate: 0h
>
> EnumeratedRealDistributionTest.testCreateFromDoubles() can sometimes fail due
> to a precision problem. More precisely, sometimes distribution.probability(2)
> equals to 0.5000000000000001, and the assertion assertEquals(0.5,
> distribution.probability(2), 0) will fail.
> The deeper reason why this happens is that the call to
> MathArrays.normalizeArray() in the constructor of EnumeratedDistribution
> (line 105) can mess up the probability for value 2 by changing it from
> exactly 0.5 to 0.5000000000000001.
> Available PR: https://github.com/apache/commons-math/pull/162
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
