SethiPandi commented on pull request #49:
URL: https://github.com/apache/commons-beanutils/pull/49#issuecomment-721801343
> Looks like your EnumConverter test is failing the build?
Ahh shoot, I'll fix that then. :thinking:
Not sure but could be 'cause I have JDK 11 as it seems to build/test for me
locally. I'll swap out and see if it makes a difference.
---
I actually just noticed a small differences between the old and new
EnumConverter, though.
The original was case-insensitive, but the new one is case-sensitive.
I was going to change it back, but verify something first as that might not
be ideal:
```java
public enum SpecialEnum {
HELLO,
hello
}
```
Despite the fact it breaches naming conventions, it's technically still
possible to have multiple enum constants with the same name if we ignore case,
so I think it's better to be case-sensitive to avoid choosing the wrong one.
I think changing it to case-sensitive might be considered a breaking change,
though?
Do you have any thoughts on if I should leave it case-sensitive, or revert
it to be non-case sensitive?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
