manishbansal8843 commented on pull request #98: URL: https://github.com/apache/commons-vfs/pull/98#issuecomment-723545847
hi @garydgregory I understand that i did not add any test cases. hence, it was not merged. But that was not the only issue. This was a critical bug and as a maintainer, i was expecting some agility from your part to address this issue. I also pointed out that existing code did not have any test case (which is not an excuse to not add new tc). Had you pointed out it earlier that it was mandatory, i would have written it. But you mentioned the same after you already merged someone else PR addressing the same issue. Had i spent effort without digging it out that existing PR has resolved this issue already, it would have wasted my time. As a maintainer, i expect you to be aware of all the PRs you are merging so that duplicate PRs can be avoided. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
