jochenw commented on pull request #125:
URL: https://github.com/apache/commons-io/pull/125#issuecomment-727274239
I would support a change, that splits the code into multiple statements. To
give an idea of what I am thinking:
byte byte0 = /* Whatever's necessary to calculate one byte */;
byte byte1 = /* Calculate another byte */;
byte byte2 = /* Calculate the third byte */
byte byte3 = /* Calculate the lasr´t byte */
long result = byte0 | (byte1 << 8) | (byte2 << 16) | (byte3 << 24);
In my opinion, that would be actually readable. The current code as well as
this proposed change aren't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
