garydgregory commented on a change in pull request #643:
URL: https://github.com/apache/commons-lang/pull/643#discussion_r523783371
##########
File path: src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
##########
@@ -424,6 +424,11 @@ private static boolean isAssignable(final Type type, final
ParameterizedType toP
return true;
}
+ //the component type should not be assignable to the array type
Review comment:
This comment is backward.
I've committed a variation of the PR to git master with more tests.
I am wondering about other Type extensions. What do you think about
`ypeUtilsTest.testIsAssignableGenericArrayTypeToWildercardType()`? See
`isAssignable(Type, Type, Map<TypeVariable<?>, Type>)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
