gwlucastrig commented on pull request #106: URL: https://github.com/apache/commons-imaging/pull/106#issuecomment-727620680
Okay. I tried that and it seems to have worked. I hope that will finish off this particular issue and I will be on to the next one... On Sat, Nov 14, 2020 at 5:49 PM Bruno P. Kinoshita <[email protected]> wrote: > *@kinow* commented on this pull request. > ------------------------------ > > In > src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffImageWriterBase.java > <https://github.com/apache/commons-imaging/pull/106#discussion_r523472686> > : > > > @@ -287,7 +330,20 @@ public void writeImage(final BufferedImage src, final OutputStream os, Map<Strin > final int width = src.getWidth(); > final int height = src.getHeight(); > > - int compression = TIFF_COMPRESSION_LZW; // LZW is default > + final ColorModel cModel = src.getColorModel(); > + final boolean hasAlpha = cModel.hasAlpha() && checkForActualAlpha(src); > > @gwlucastrig <https://github.com/gwlucastrig> I just had a look at your > forked repo, and I believe I am able to push changes to your branch Gary. > That's because by default pull requests allow contributors of a repository > to push against the original branch of the pull request. > > In that case, you should be able to push to your branch too. In a brand > new directory, here's what I'd do: > > git clone [email protected]:gwlucastrig/commons-imaging.git -o origin > git checkout issue-216 > vim src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffImageWriterBase.java > git add . > git commit -m '[IMAGING-216] Updated documentation for TIFF writer base class' > git push -u origin issue-216 > > After that the new commit would appear here. > > I used a new directory as that's what I'd have to do in my machine to push > to your branch. But if you have a working directory with commons-imaging, > you can try to use that to experiment with git and try to push to this PR. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-imaging/pull/106#discussion_r523472686>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEWJDYI7CQ6FHWNEGUTFYHLSP4CPBANCNFSM4TE4QL7A> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
