garydgregory commented on pull request #171: URL: https://github.com/apache/commons-io/pull/171#issuecomment-735422984
IMO, you need better tests with edge cases like input size of 0, 1, 2, 4, 8, and the "usual" buffer sizes from other streams like 4096 or the more recent 8192 (private java.io.BufferedInputStream.DEFAULT_BUFFER_SIZE). You can parameterize the tests with normal JUnit features. Someone (like me ;-) will invariably look at the current implementation and not like the one byte at a time implementations since normal streams usually work on buffers, but that's a different story, let's start with better tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
