singhbaljit commented on a change in pull request #112:
URL: https://github.com/apache/commons-geometry/pull/112#discussion_r538691487
##########
File path:
commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Bounds3DTest.java
##########
@@ -125,29 +125,12 @@ public void testFrom_invalidBounds() {
final Vector3D negInf = Vector3D.of(1, 1, Double.NEGATIVE_INFINITY);
// act/assert
- GeometryTestUtils.assertThrows(() -> {
- Bounds3D.from(Vector3D.NaN);
- }, IllegalStateException.class, INVALID_BOUNDS_PATTERN);
-
- GeometryTestUtils.assertThrows(() -> {
- Bounds3D.from(Vector3D.POSITIVE_INFINITY);
- }, IllegalStateException.class, INVALID_BOUNDS_PATTERN);
-
- GeometryTestUtils.assertThrows(() -> {
- Bounds3D.from(Vector3D.NEGATIVE_INFINITY);
- }, IllegalStateException.class, INVALID_BOUNDS_PATTERN);
-
- GeometryTestUtils.assertThrows(() -> {
- Bounds3D.from(good, nan);
- }, IllegalStateException.class, INVALID_BOUNDS_PATTERN);
-
- GeometryTestUtils.assertThrows(() -> {
- Bounds3D.from(posInf, good);
- }, IllegalStateException.class, INVALID_BOUNDS_PATTERN);
-
- GeometryTestUtils.assertThrows(() -> {
- Bounds3D.from(good, negInf, good);
- }, IllegalStateException.class, INVALID_BOUNDS_PATTERN);
+ assertThrows(IllegalStateException.class, () ->
Bounds3D.from(Vector3D.NaN));
Review comment:
`assertThrows` returns the exception instance, which can be used to
validate the message pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
