[ 
https://issues.apache.org/jira/browse/MATH-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Randy Strauss updated MATH-1565:
--------------------------------
    Summary: Fix included: MatrixUtils.checkColumnIndex() uses COLUMN_INDEX 
instead of COLUMN_INDEX_OUT_OF_RANGE  (was: MatrixUtils.checkColumnIndex() uses 
COLUMN_INDEX instead of COLUMN_INDEX_OUT_OF_RANGE)

> Fix included: MatrixUtils.checkColumnIndex() uses COLUMN_INDEX instead of 
> COLUMN_INDEX_OUT_OF_RANGE
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MATH-1565
>                 URL: https://issues.apache.org/jira/browse/MATH-1565
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.6.1
>            Reporter: Randy Strauss
>            Priority: Trivial
>         Attachments: MatrixUtils.java, MatrixUtilsTest.java, diff.txt
>
>
> MatrixUtils.checkColumnIndex() uses COLUMN_INDEX instead of 
> COLUMN_INDEX_OUT_OF_RANGE
>  similarly for checkRowIndex
> Note that testing could run a script that searches the code for all the 
> LocalizedFormats, and complains if any of them are not used.  In this case, 
> it would have caught this error.
> Another test that would have caught it is parsing the code and checking that 
> the number of arguments matches the number of percent signs.
> =====
> Attached is a fix and a test, both a diff and the 2 files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to