[
https://issues.apache.org/jira/browse/CRYPTO-151?focusedWorklogId=523431&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-523431
]
ASF GitHub Bot logged work on CRYPTO-151:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/20 16:41
Start Date: 12/Dec/20 16:41
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #114:
URL: https://github.com/apache/commons-crypto/pull/114#issuecomment-743781742
> Hi @garydgregory
> As you can imaginate I don't think validating the exception message will
helps with the functional testing. But in any case, i made the revert and adapt
to JUnit 5.
> I've check of all the new change
@arturobernalg
Maybe so, but this is a large PR that is _supposed_ to only _port_ the tests
from JUnit 4 to 5, so it is best IMO to _not_ change _what_ is being tested or
_how_ it is being tested.
As you can imagine, it's a slog to go through a large PR ;-)
If you want to improve the tests beyond this port, then sure go ahead, but I
don't see a case for removing something successfully tested for now.
Gary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 523431)
Time Spent: 2.5h (was: 2h 20m)
> Migrate to Junit 5
> ------------------
>
> Key: CRYPTO-151
> URL: https://issues.apache.org/jira/browse/CRYPTO-151
> Project: Commons Crypto
> Issue Type: Improvement
> Affects Versions: 1.1.0
> Reporter: Arturo Bernal
> Priority: Minor
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
