[
https://issues.apache.org/jira/browse/COMPRESS-561?focusedWorklogId=523728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-523728
]
ASF GitHub Bot logged work on COMPRESS-561:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Dec/20 07:24
Start Date: 14/Dec/20 07:24
Worklog Time Spent: 10m
Work Description: PeterAlfredLee commented on a change in pull request
#157:
URL: https://github.com/apache/commons-compress/pull/157#discussion_r542161610
##########
File path:
src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveOutputStream.java
##########
@@ -137,14 +137,15 @@ private long writeEntryHeader(final ArArchiveEntry
pEntry) throws IOException {
boolean mustAppendName = false;
final String n = pEntry.getName();
- if (LONGFILE_ERROR == longFileMode && n.length() > 16) {
+ final int nLength = n.length();
Review comment:
I can't see much benefit from extracting `n.length()` to a final
`nlength`. Maybe it's performance benefiting or something else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 523728)
Time Spent: 40m (was: 0.5h)
> Minor improvement
> -----------------
>
> Key: COMPRESS-561
> URL: https://issues.apache.org/jira/browse/COMPRESS-561
> Project: Commons Compress
> Issue Type: Improvement
> Reporter: Arturo Bernal
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Minor improvement
>
> * Unused import
> * add final
> * Replace Charset.forName("UTF-8") for --> StandardCharsets.UTF_8
> * Unnecessary semicolon ''
> *
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
