leskin-in commented on pull request #175:
URL: https://github.com/apache/commons-io/pull/175#issuecomment-745514116


   Adding a test for this change (e.g. to 
[`IOUtilsTestCase`](https://github.com/apache/commons-io/blob/5dd0f87c8e37c7838ef336e20307caf24b61c329/src/test/java/org/apache/commons/io/IOUtilsTestCase.java#L1324))
 seems quite complicated: `ByteArrayInputStream`, and `BufferedInputStream` 
both use common Java arrays, whose length is not enough for the test.
   
   A solution I can think of is to use `FileInputStream`; but this would 
require the test case to create a 2Gb file, which IMHO does not look good.
   
   It is also possible to implement a custom `InputStream`. It may turn to be 
useful in other tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to