kinow commented on a change in pull request #677:
URL: https://github.com/apache/commons-lang/pull/677#discussion_r546215376



##########
File path: src/main/java/org/apache/commons/lang3/RandomStringUtils.java
##########
@@ -309,8 +309,10 @@ public static String random(final int count, final int 
start, final int end, fin
      * @param count  the length of random string to create
      * @param start  the position in set of chars to start at
      * @param end  the position in set of chars to end before
-     * @param letters  only allow letters?
-     * @param numbers  only allow numbers?
+     * @param letters  if {@code true}, generated string may include
+     *  alphabetic characters
+     * @param numbers  if {@code true}, generated string may include
+     *  numeric characters

Review comment:
       Hi @aviProgrammer , thanks for your pull request.
   
   It looks like a good contribution! And I was ready to approve it, but I 
noticed we can fix it in another line further down, where the same comments 
appear.
   
   If you are using the GitHub UI to read this reply, you can click on the blue 
arrow here twice, and on lines 348 and 349 you should find these same 
parameters I think.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to