[
https://issues.apache.org/jira/browse/LANG-1628?focusedWorklogId=526260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-526260
]
ASF GitHub Bot logged work on LANG-1628:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Dec/20 09:19
Start Date: 19/Dec/20 09:19
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #677:
URL: https://github.com/apache/commons-lang/pull/677#discussion_r546215376
##########
File path: src/main/java/org/apache/commons/lang3/RandomStringUtils.java
##########
@@ -309,8 +309,10 @@ public static String random(final int count, final int
start, final int end, fin
* @param count the length of random string to create
* @param start the position in set of chars to start at
* @param end the position in set of chars to end before
- * @param letters only allow letters?
- * @param numbers only allow numbers?
+ * @param letters if {@code true}, generated string may include
+ * alphabetic characters
+ * @param numbers if {@code true}, generated string may include
+ * numeric characters
Review comment:
Hi @aviProgrammer , thanks for your pull request.
It looks like a good contribution! And I was ready to approve it, but I
noticed we can fix it in another line further down, where the same comments
appear.
If you are using the GitHub UI to read this reply, you can click on the blue
arrow here twice, and on lines 348 and 349 you should find these same
parameters I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 526260)
Remaining Estimate: 0h
Time Spent: 10m
> Javadoc for RandomStringUtils.random() letters, numbers parameters is wrong
> ---------------------------------------------------------------------------
>
> Key: LANG-1628
> URL: https://issues.apache.org/jira/browse/LANG-1628
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
> Affects Versions: 3.11
> Reporter: Jarkko Rantavuori
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> For two of the random() methods, these:
> public static String random(int count, int start, int end, boolean letters,
> boolean numbers, char... chars)
> public static String random(int count, int start, int end, boolean letters,
> boolean numbers, char[] chars, Random random)
> the javadoc for letters, numbers parameters is
> {{letters}} - only allow letters?
> {{numbers}} - only allow numbers?
> when it should be like in other random() methods:
> {{letters}} - if {{true}}, generated string may include alphabetic characters
> {{numbers}} - if {{true}}, generated string may include numeric characters
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
