garydgregory commented on pull request #676: URL: https://github.com/apache/commons-lang/pull/676#issuecomment-749119583
Hi @subhamgupta26 Thank you for your PR. While this change fixes 2 NPEs, it leaves the rest of Commons Lang to treat null Locales inconsistently, some null Locales work for APIs you updates, but others will fail. Please see git master for updates to treat null Locales as the default Locale consistently throughout the code base. If you think there is more to do, then please feel free to rebase your PR on master and further update it. If the code base satisfies your use cases, then please close it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
