arturobernalg commented on a change in pull request #123:
URL: https://github.com/apache/commons-geometry/pull/123#discussion_r547103104
##########
File path:
commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/rotation/Rotation2DTest.java
##########
@@ -150,20 +150,18 @@ public void testCreateRotationVector() {
final double max = 8;
final double step = 1;
- EuclideanTestUtils.permuteSkipZero(min, max, step, (ux, uy) -> {
- EuclideanTestUtils.permuteSkipZero(min, max, step, (vx, vy) -> {
+ EuclideanTestUtils.permuteSkipZero(min, max, step, (ux, uy) ->
EuclideanTestUtils.permuteSkipZero(min, max, step, (vx, vy) -> {
Review comment:
OK. reverted
##########
File path:
commons-geometry-core/src/test/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractPartitionedRegionBuilderTest.java
##########
@@ -38,9 +38,7 @@ public void testCtor_invalidTree() {
final TestRegionBSPTree tree = new TestRegionBSPTree(true);
// act/assert
- GeometryTestUtils.assertThrowsWithMessage(() -> {
- new TestRegionBuilder(tree);
- }, IllegalArgumentException.class, "Tree must be empty");
+ GeometryTestUtils.assertThrowsWithMessage(() -> new
TestRegionBuilder(tree), IllegalArgumentException.class, "Tree must be empty");
Review comment:
reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
