darkma773r commented on a change in pull request #122:
URL: https://github.com/apache/commons-geometry/pull/122#discussion_r547373970
##########
File path:
commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Bounds3D.java
##########
@@ -233,7 +233,7 @@ public Builder add(final Vector3D pt) {
* @param pts points to add
* @return this instance
*/
- public Builder addAll(final Iterable<Vector3D> pts) {
+ public Builder addAll(final Iterable<? extends Vector3D> pts) {
Review comment:
Users can't create their own `Vector3D` subclasses since the constructor
is private. I don't see a reason to prevent use of `Iterable<Vector3D.Unit>`,
though, so I think we should go ahead with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
