aherbert commented on pull request #87: URL: https://github.com/apache/commons-numbers/pull/87#issuecomment-750902544
The 'final' status of parameters is enforced in the project using PMD rules: `AvoidReassigningParameters`. However we have avoided using final in the code as it adds visual noise to the source code and the PMD rule `MethodArgumentCouldBeFinal` is disabled. There is no benefit of final method arguments to the JVM compiler, which knows about effectively final variables for example those that can be referenced inside lambda statements. As such it is difficult to see what other modifications are in the PR. Can you remove the use of final for method arguments and then it will be clear what is left? The use of final for method params is a style choice and you can raise this on the dev mailing list to start a discussion about what is preferred. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
