garydgregory commented on a change in pull request #56:
URL: https://github.com/apache/commons-cli/pull/56#discussion_r549013735
##########
File path: src/main/java/org/apache/commons/cli/CommandLineParser.java
##########
@@ -36,11 +36,11 @@
*/
CommandLine parse(Options options, String[] arguments) throws
ParseException;
- /**
Review comment:
Leave as Javadoc since one can specify to Javadoc what level of
visibility to document for the generated site.
##########
File path: src/test/java/org/apache/commons/cli/TypeHandlerTest.java
##########
@@ -77,7 +77,7 @@ public void testCreateValueNumber_Double()
public void testCreateValueNumber_Long()
throws Exception
{
- assertEquals(Long.valueOf(15), TypeHandler.createValue("15",
PatternOptionBuilder.NUMBER_VALUE));
+ assertEquals(15L, TypeHandler.createValue("15",
PatternOptionBuilder.NUMBER_VALUE));
Review comment:
-1 Don't hiding the boxing which is the point of the test, see method
name.
##########
File path: src/test/java/org/apache/commons/cli/ValuesTest.java
##########
@@ -140,10 +140,10 @@ public void testCharSeparator()
assertArrayEquals(new String[] { "key", "value" },
cmd.getOptionValues('m'));
}
- /**
- * jkeyes - commented out this test as the new architecture
- * breaks this type of functionality. I have left the test
- * here in case I get a brainwave on how to resolve this.
+ /*
Review comment:
-1 Don't undo Javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
