[
https://issues.apache.org/jira/browse/DBCP-567?focusedWorklogId=528831&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-528831
]
ASF GitHub Bot logged work on DBCP-567:
---------------------------------------
Author: ASF GitHub Bot
Created on: 28/Dec/20 17:27
Start Date: 28/Dec/20 17:27
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #68:
URL: https://github.com/apache/commons-dbcp/pull/68#discussion_r549424454
##########
File path: src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
##########
@@ -94,6 +100,8 @@
private Integer defaultQueryTimeoutSeconds;
+ private final ExecutorService executor = Executors.newFixedThreadPool(3,
new AbortThreadFactory());
Review comment:
Hi @rmannibucau
I merged this PR and implemented my 2 comments.
May you please follow up on your comment above with a new PR?
TY!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 528831)
Remaining Estimate: 0h
Time Spent: 10m
> Use abort rather than close to clean up abandoned connections
> -------------------------------------------------------------
>
> Key: DBCP-567
> URL: https://issues.apache.org/jira/browse/DBCP-567
> Project: Commons DBCP
> Issue Type: Improvement
> Reporter: Phil Steitz
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Using abort rather than close to disconnect abandoned connections will make
> it less likely that pool threads get stuck waiting for locks on abandoned
> connections.
> To implement this, we will need the changes in [Pool
> 387|https://issues.apache.org/jira/browse/POOL-387]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
