theobisproject commented on pull request #113: URL: https://github.com/apache/commons-compress/pull/113#issuecomment-752253262
I've gone through the changes once more and noticed the changes from COMPRESS-559 is missing for the sparse entry test with `TarFile`. > Are there any other work left now? @theobisproject I'd like to hear your opinion about my TODO comments in the `SparseFilesTest`. I left out the `canReadEntryData` method which the `TarArchiveInputStream` has but kept the checks in my added tests. I don't think we need this method because the `TarFile#getInputStream` only takes an instance of `TarArchiveEntry`. Should I add this method or just remove the commented out code? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
