garydgregory commented on a change in pull request #127:
URL: https://github.com/apache/commons-csv/pull/127#discussion_r549884810



##########
File path: src/test/java/org/apache/commons/csv/CSVParserTest.java
##########
@@ -427,7 +427,7 @@ public void testExcelFormat2() throws Exception {
     /**
      * Tests an exported Excel worksheet with a header row and rows that have 
more columns than the headers
      *
-     * @throws Exception
+     * @throws Exception Any exception can be thrown

Review comment:
       Not helpful. Tests like this one can throw `Exception` as a convention 
instead of throwing a potentially long list of exceptions which are not useful 
and just clutter up the method signatures. So either we should not have a 
Javadoc tag or if we have one, it should carry proper and useful documentation. 
In this case, I think that there is nothing interesting to say. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to