SethFalco commented on pull request #50: URL: https://github.com/apache/commons-beanutils/pull/50#issuecomment-752289596
> If you have no internet, you won't be able to build anyway since Maven will download plugins to get the build off the ground. > I appreciate this, however it's common to try minimise any reason a unit test fails other than from what the unit test is testing. The URLConverter tests are only intended to test the conversion to the URL type. An internet connection, or if URLs resolve to the same host shouldn't be in scope for the test. Currently, it can fail when what we want to test is correct. At the point one has already cloned the repo, and already resolved all dependencies and plugins, I firmly believe they shouldn't need internet to run unit tests locally. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
