garydgregory commented on a change in pull request #179:
URL: https://github.com/apache/commons-io/pull/179#discussion_r550254270
##########
File path: src/main/java/org/apache/commons/io/FilenameUtils.java
##########
@@ -665,7 +665,10 @@ public static int getPrefixLength(final String fileName) {
if (ch1 == ':') {
ch0 = Character.toUpperCase(ch0);
if (ch0 >= 'A' && ch0 <= 'Z') {
- if (len == 2 || isSeparator(fileName.charAt(2)) == false) {
+ if (len == 2 &&
!FileSystem.getCurrent().supportsDriveLetter()) {
Review comment:
Well, our current Javadoc is lame because while this methods returns an
`int`, the Javadoc shows `String` examples as 'output' which is not so helpful
IMO, so if you can fix the Javadoc to show what the `int` value is now for all
the example strings, that would be appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
