garydgregory commented on a change in pull request #47:
URL: https://github.com/apache/commons-beanutils/pull/47#discussion_r550264772
##########
File path: src/main/java/org/apache/commons/beanutils2/ConvertUtilsBean.java
##########
@@ -516,10 +534,13 @@ private void registerStandard(final boolean
throwException, final boolean defaul
private void registerOther(final boolean throwException) {
// @formatter:off
register(Class.class, throwException ? new ClassConverter()
: new ClassConverter(null));
+ register(ColorConverter.class, throwException ? new ColorConverter()
: new ColorConverter(null));
register(Enum.class, throwException ? new EnumConverter()
: new EnumConverter(null));
Review comment:
Isn't the first argument supposed to be Color? If so, how are the tests
passing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
