[
https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=530433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530433
]
ASF GitHub Bot logged work on IO-670:
-------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/21 17:30
Start Date: 03/Jan/21 17:30
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-753650101
Hello @XenoAmess
We already have a lot of changes for the next release, so I want to manage
expectations such that I would I prefer to get out 3.12 before making even more
big changes like these.
But still, let's continue this thread. Starting with the lowest-level bits:
we need to justify the addition of the misnamed `Unsync*` classes, the prefix
should be `Unsynchronized` like our existing
`UnsynchronizedByteArrayInputStream`, which I've already mentioned.
We need performances test that show the differences, if any, between the
JRE's classes and our proposed `Unsynchronized` versions. Since you propose two
such classes `UnsyncBufferedInputStream` and `UnsyncBufferedReader`, that's two
new tests. Or did I miss these here?
I think you should create a new PR for just these two new classes and their
tests. This will make the work simpler for everyone when reviewing and testing.
TY.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 530433)
Time Spent: 13h 40m (was: 13.5h)
> IOUtils.contentEquals is of low performance. I will refine it.
> --------------------------------------------------------------
>
> Key: IO-670
> URL: https://issues.apache.org/jira/browse/IO-670
> Project: Commons IO
> Issue Type: Improvement
> Reporter: Jin Xu
> Priority: Critical
> Attachments: jmh-result.org.apache.json
>
> Time Spent: 13h 40m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-io/pull/118]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
