[
https://issues.apache.org/jira/browse/COMPRESS-540?focusedWorklogId=530737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530737
]
ASF GitHub Bot logged work on COMPRESS-540:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/21 15:58
Start Date: 04/Jan/21 15:58
Worklog Time Spent: 10m
Work Description: theobisproject commented on a change in pull request
#113:
URL: https://github.com/apache/commons-compress/pull/113#discussion_r551404112
##########
File path: src/test/java/org/apache/commons/compress/archivers/TarTestCase.java
##########
@@ -335,6 +482,18 @@ public void testCOMPRESS178() throws Exception {
in.close();
}
+ @Test
+ public void testTarFileCOMPRESS178() throws Exception {
+ final File input = getFile("COMPRESS-178.tar");
+ try (final TarFile tarFile = new TarFile(input)) {
+ // Compared to the TarArchiveInputStream all entries are read when
instantiating the tar file
+ fail("Expected IOException");
+ } catch (final IOException e) {
Review comment:
`assertThrows` is not available in Junit 4. The test is equivalent to
the already exisiting test for the `TarArchiveInputStream`. Should I change
both tests to use the `expected` property in the `@Test` annotation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 530737)
Time Spent: 9h (was: 8h 50m)
> Random access on Tar archive
> ----------------------------
>
> Key: COMPRESS-540
> URL: https://issues.apache.org/jira/browse/COMPRESS-540
> Project: Commons Compress
> Issue Type: Improvement
> Reporter: Robin Schimpf
> Priority: Major
> Time Spent: 9h
> Remaining Estimate: 0h
>
> The TarArchiveInputStream only provides sequential access. If only a small
> amount of files from the archive is needed large amount of data in the input
> stream needs to be skipped.
> Therefore I was working on a implementation to provide random access to
> TarFiles equal to the ZipFile api. The basic idea behind the implementation
> is the following
> * Random access is backed by a SeekableByteChannel
> * Read all headers of the tar file and save the place to the data of every
> header
> * User can request an input stream for any entry in the archive multiple
> times
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
