[
https://issues.apache.org/jira/browse/CRYPTO-156?focusedWorklogId=531290&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531290
]
ASF GitHub Bot logged work on CRYPTO-156:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jan/21 15:12
Start Date: 05/Jan/21 15:12
Worklog Time Spent: 10m
Work Description: arturobernalg opened a new pull request #127:
URL: https://github.com/apache/commons-crypto/pull/127
In order to avoid duplicate code and try to unify the transformation of the
token i think it's necessary create the next class:
OpenSslTransform --> Utility code for dealing with different algorithm types
OpenSslPadding --> Containg the enumeration of Cipher Algorithm Padding
OpenSslAlgorithmMode --> Enumeration of Algorithm Mode.
https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L208
https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L422
https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L47
https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 531290)
Time Spent: 2h 20m (was: 2h 10m)
> Common Class Padding, Transform and AlgorithmMode
> -------------------------------------------------
>
> Key: CRYPTO-156
> URL: https://issues.apache.org/jira/browse/CRYPTO-156
> Project: Commons Crypto
> Issue Type: Improvement
> Components: Cipher
> Affects Versions: 1.1.0
> Reporter: Arturo Bernal
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.1.1
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> In order to avoid duplicate code and try to unify the transformation of the
> token i think it's necessary create the next class/enum:
> * {{OpenSslTransform}} --> Utility code for dealing with different algorithm
> types
> * {{OpenSslPadding}} --> Containg the enumeration of Cipher Algorithm Padding
> * {{OpenSslAlgorithmMode}} --> Enumeration of Algorithm Mode.
> [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L208]
>
> [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L422]
>
> [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L47]
>
> [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L399]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
