[
https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=532114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532114
]
ASF GitHub Bot logged work on IO-698:
-------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/21 20:25
Start Date: 06/Jan/21 20:25
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #184:
URL: https://github.com/apache/commons-io/pull/184#discussion_r552944750
##########
File path:
src/test/java/org/apache/commons/io/performance/IOUtilsContentEqualsPerformanceTest.java
##########
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.io.performance;
+
+import java.io.BufferedInputStream;
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringReader;
+import java.util.concurrent.TimeUnit;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.io.input.buffer.UnsynchronizedBufferedInputStream;
+import org.apache.commons.io.input.buffer.UnsynchronizedBufferedReader;
+import org.apache.commons.lang3.StringUtils;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.Warmup;
+import org.openjdk.jmh.infra.Blackhole;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+@Warmup(iterations = 1, time = 10, timeUnit = TimeUnit.SECONDS)
+@Measurement(iterations = 1, time = 10, timeUnit = TimeUnit.SECONDS)
+@Fork(value = 1, jvmArgs = {"-server"})
+public class IOUtilsContentEqualsPerformanceTest {
+ static String[] STRINGS = new String[1];
+
+ static {
+ STRINGS[0] = StringUtils.repeat("ab", 1 << 24);
+ }
+
+ @Benchmark
+ public void testBufferedInputStream(Blackhole blackhole) throws
IOException {
+ try (
+ InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+ BufferedInputStream bufferedInputStream = new
BufferedInputStream(inputStream)
+ ) {
+ while (true) {
+ int nowI = bufferedInputStream.read();
+ // do nothing
+ blackhole.consume(nowI);
+ if (nowI != -1) {
+ break;
+ }
+ }
+ }
+ }
+
+ @Benchmark
+ public void testUnsynchronizedBufferedInputStream(Blackhole blackhole)
throws IOException {
+ try (
+ InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+ UnsynchronizedBufferedInputStream bufferedInputStream = new
UnsynchronizedBufferedInputStream(inputStream)
+ ) {
+ while (true) {
+ int nowI = bufferedInputStream.read();
+ // do nothing
+ blackhole.consume(nowI);
+ if (nowI != -1) {
+ break;
+ }
+ }
+ }
+ }
+
+ @Benchmark
+ public void testBufferedReader(Blackhole blackhole) throws IOException {
+ try (
+ StringReader inputReader = new StringReader(STRINGS[0]);
+ BufferedReader bufferedReader = new BufferedReader(inputReader)
+ ) {
+ while (true) {
+ int nowI = bufferedReader.read();
+ // do nothing
+ blackhole.consume(nowI);
+ if (nowI != -1) {
+ break;
+ }
+ }
+ }
+ }
+
+ @Benchmark
+ public void testUnsynchronizedBufferedReader(Blackhole blackhole) throws
IOException {
+ try (
+ StringReader inputReader = new StringReader(STRINGS[0]);
+ UnsynchronizedBufferedReader bufferedReader = new
UnsynchronizedBufferedReader(inputReader)
+ ) {
+ while (true) {
+ int nowI = bufferedReader.read();
+ // do nothing
+ blackhole.consume(nowI);
+ if (nowI != -1) {
+ break;
+ }
+ }
+ }
+ }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ @Benchmark
+ public void testBufferedInputStream2(Blackhole blackhole) throws
IOException {
+ try (
+ InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+ BufferedInputStream bufferedInputStream = new
BufferedInputStream(inputStream)
+ ) {
+ byte[] bytes = new byte[1];
+ while (true) {
+ int nowI = bufferedInputStream.read(bytes , 0, 1);
+ // do nothing
+ blackhole.consume(nowI);
+ if (nowI != -1) {
+ break;
+ }
+ }
+ }
+ }
+
+ @Benchmark
+ public void testUnsynchronizedBufferedInputStream2(Blackhole blackhole)
throws IOException {
+ try (
+ InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+ UnsynchronizedBufferedInputStream bufferedInputStream = new
UnsynchronizedBufferedInputStream(inputStream)
+ ) {
+ byte[] bytes = new byte[1];
+ while (true) {
+ int nowI = bufferedInputStream.read(bytes , 0, 1);
+ // do nothing
+ blackhole.consume(nowI);
+ if (nowI != -1) {
+ break;
+ }
+ }
+ }
+ }
+
+ @Benchmark
+ public void testBufferedReader2(Blackhole blackhole) throws IOException {
+ try (
+ StringReader inputReader = new StringReader(STRINGS[0]);
+ BufferedReader bufferedReader = new BufferedReader(inputReader)
+ ) {
+ char[] bytes = new char[1];
+ while (true) {
+ int nowI = bufferedReader.read(bytes , 0, 1);
+ // do nothing
+ blackhole.consume(nowI);
+ if (nowI != -1) {
+ break;
+ }
+ }
+ }
+ }
+
+ @Benchmark
+ public void testUnsynchronizedBufferedReader2(Blackhole blackhole) throws
IOException {
Review comment:
A "2" postfix for a method name says nothing about why its different
from the plain method name. Please give it a name that better describes what
you are testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 532114)
Time Spent: 1.5h (was: 1h 20m)
> add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
> ----------------------------------------------------------------
>
> Key: IO-698
> URL: https://issues.apache.org/jira/browse/IO-698
> Project: Commons IO
> Issue Type: Improvement
> Components: Streams/Writers
> Reporter: Jin Xu
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> https://github.com/apache/commons-io/pull/184
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
