garydgregory commented on a change in pull request #129:
URL: https://github.com/apache/commons-crypto/pull/129#discussion_r554005510
##########
File path: src/main/java/org/apache/commons/crypto/random/OsCryptoRandom.java
##########
@@ -74,7 +76,7 @@ public OsCryptoRandom(final Properties props) {
try {
close();
- this.stream = new FileInputStream(randomDevFile);
+ this.stream =
Files.newInputStream(Paths.get(randomDevFile.getPath()));
Review comment:
This is coded in a pretty obtuse manner, if the point is to use NIO,
then start with a Path instead of a File.
In general, it feels to me like you need to step back and look at the big
picture instead of applying whatever micro changes your IDE offers (or PMD, and
so on).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
