garydgregory commented on pull request #184: URL: https://github.com/apache/commons-io/pull/184#issuecomment-757553373
> > > @garydgregory rerun performance tests: > > > https://pastebin.ubuntu.com/p/njnG5x78fD/ > > > seems no significant performance improvement in this two classes (comparing with sync ones in original jdk). > > > so maybe I should close this pr and migrate [IO-670] to use the version in jdk. > > > What is your opinion? > > > > > > @arturobernalg > > Am I reading the summary correctly in that the average times of some tests for the new code is slight _slower_? > > @garydgregory seems so. > wondering why, but have no very good ideas. @arturobernalg So... if it's only a tiny bit better on average (<0.01%) but can be worse in some cases, and also worse if you take into account the error measurement, then...? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
