[
https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=534911&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534911
]
ASF GitHub Bot logged work on IO-698:
-------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/21 15:59
Start Date: 12/Jan/21 15:59
Worklog Time Spent: 10m
Work Description: XenoAmess commented on pull request #184:
URL: https://github.com/apache/commons-io/pull/184#issuecomment-758755089
> > > > @garydgregory rerun performance tests:
> > > > https://pastebin.ubuntu.com/p/njnG5x78fD/
> > > > seems no significant performance improvement in this two classes
(comparing with sync ones in original jdk).
> > > > so maybe I should close this pr and migrate [IO-670] to use the
version in jdk.
> > > > What is your opinion?
> > >
> > >
> > > @arturobernalg
> > > Am I reading the summary correctly in that the average times of some
tests for the new code is slight _slower_?
> >
> >
> > @garydgregory seems so.
> > wondering why, but have no very good ideas.
>
> @arturobernalg
> So... if it's only a tiny bit better on average (<0.01%) but can be worse
in some cases, and also worse if you take into account the error measurement,
then...?
@garydgregory Yep, so maybe I should close this pr and migrate [IO-670] to
use the version in jdk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 534911)
Time Spent: 5h 20m (was: 5h 10m)
> add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
> ----------------------------------------------------------------
>
> Key: IO-698
> URL: https://issues.apache.org/jira/browse/IO-698
> Project: Commons IO
> Issue Type: Improvement
> Components: Streams/Writers
> Reporter: Jin Xu
> Priority: Minor
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> https://github.com/apache/commons-io/pull/184
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
